Merged
Conversation
slax57
requested changes
Jan 10, 2025
slax57
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We had many issues in the past with incompatible video formats or codecs on video assets used in the documentation (e.g. not readable on Firefox or Ubuntu+Chrome)
We risk doing the same error in the future, as our screen capture tools seem to produce erroneous videos by default
Solution
Add a CI step to check the video asset files
How To Test
make check-documentation-videos-formatAdditional Checks
masterfor a bugfix, ornextfor a feature