Conversation
erwanMarmelab
approved these changes
Jan 22, 2025
slax57
reviewed
Jan 23, 2025
|
|
||
| const pageTitle = translate('ra.page.edit', { | ||
| name: getResourceLabel('products', 1), | ||
| recordRepresentation: `"${record?.reference}"`, |
Contributor
There was a problem hiding this comment.
nitpick: you lost the wrapping with "
slax57
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The demo introduced a custom
usePageTitlehook that re-implemented logic already available in the different views contexts.Solution
Simplify demo titles by using the views contexts.
How To Test
Open the demo then check each page still has its title and also have a translated browser tab title.
Additional Checks
masterfor a bugfix, ornextfor a featureAlso, please make sure to read the contributing guidelines.