Fix <AutocompleteInput> can flicker when used in a <FormDataConsumer>

[slax57]

Problem

Fixes #10415

Supersedes #10417 (which was reverted in 3f6a312 as it caused other issues notably with StackedFilters).

Solution

The flicker actually comes from a missing memoization of the optionText prop in the <AutocompleteInput> component.

How To Test

• Story without the fix: https://react-admin-storybook.vercel.app/?path=/story/ra-core-form-formdataconsumer--basic
• Story with the fix: http://localhost:9010/?path=/story/ra-core-form-formdataconsumer--basic

For both: Enter a title then select a user. Notice the flicker each time you change the user value. You might have to set a CPU throttle in your devtool to notice it.

---

FTR: Also added a story allowing to reproduce the issue the first fix attempt created in the StackedFilters component.
To reproduce the bug:

1. Open story: http://localhost:9010/?path=/story/ra-core-form-formdataconsumer--stacked-filters
2. Add a new filter, leave every input blank
3. Remove the newly added filter
4. Add a new filter again
5. This should trigger an error: Cannot read properties of null (reading 'focus')

Additional Checks

• The PR targets master for a bugfix, or next for a feature
• The PR includes unit tests (if not possible, describe why): not possible
• The PR includes one or several stories (if not possible, describe why)
• The documentation is up to date

Also, please make sure to read the contributing guidelines.

[slax57]

In the end I did not use this story, as we did not change the FormDataConsumer implementation. But I figured we could still keep it to ease tests later. Wdyt, should we keep it?

[djhi]

yes, let's keep it

[slax57]

Some tests are failing 🙁 . Back to WIP.

[slax57]

It turns out memoizing the optionText callback is not that easy, because it is used in the render phase (so useEvent will throw an error).
Memoizing it would require a partial refactor of AutocompleteInput to make sure this prop is not used during the render phase.
We may do that eventually, but this requires quite a lot of work.

Additionally, we wanted to document the fact that, for now, it's up to the user to make sure to pass a stable reference to the optionText prop. But it turns out it's already documented!

So, for these reasons, I'm closing this PR.