[Chore] Remove doc from published react-admin package#10505
Merged
fzaninotto merged 2 commits intomasterfrom Feb 11, 2025
Merged
[Chore] Remove doc from published react-admin package#10505fzaninotto merged 2 commits intomasterfrom
fzaninotto merged 2 commits intomasterfrom
Conversation
fzaninotto
reviewed
Feb 10, 2025
|
|
||
| build-react-admin: | ||
| @echo "Transpiling react-admin files..."; | ||
| @rm -rf ./packages/react-admin/docs |
Member
There was a problem hiding this comment.
You should probably keep this one for those of us who have an old copy of the docs
erwanMarmelab
approved these changes
Feb 10, 2025
djhi
commented
Feb 11, 2025
fzaninotto
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We currently include a copy of the
docsdirectory in the publishedreact-adminpackage. This makes it quite heavy and is probably useless.Solution
docsdirectory when building the package.docsdirectory from the included files of thepackage.jsonforreact-adminAdditional Checks
masterfor a bugfix, ornextfor a feature