Improve <DeleteButton> and <UpdateButton> confirmation wording using record representation

[djhi]

Problem

<DeleteButton> and <UpdateButton> confirmation dialog titles show a very generic message but we can do better thanks to the record representation.

Solution

• If a resource has a string record representation, use it.
• To avoid breaking changes, introduce new translation keys where needed

How To Test

<DeleteButton>

• https://react-admin-storybook-j5tx6l6fc-marmelab.vercel.app/?path=/story/ra-ui-materialui-button-deletewithconfirmbutton--basic
• https://react-admin-storybook-j5tx6l6fc-marmelab.vercel.app/?path=/story/ra-ui-materialui-button-deletewithconfirmbutton--no-record-representation
• https://react-admin-storybook-j5tx6l6fc-marmelab.vercel.app/?path=/story/ra-ui-materialui-button-deletewithconfirmbutton--with-custom-dialog-content

<UpdateButton>

• https://react-admin-storybook-j5tx6l6fc-marmelab.vercel.app/?path=/story/ra-ui-materialui-button-updatewithconfirmbutton--basic
• https://react-admin-storybook-j5tx6l6fc-marmelab.vercel.app/?path=/story/ra-ui-materialui-button-updatewithconfirmbutton--no-record-representation
• https://react-admin-storybook-j5tx6l6fc-marmelab.vercel.app/?path=/story/ra-ui-materialui-button-updatewithconfirmbutton--with-custom-dialog-content

Screenshots

<DeleteButton>

Before

After

<UpdateButton>

Before

After

Additional Checks

• The PR targets master for a bugfix or a documentation fix, or next for a feature
• The PR includes unit tests (if not possible, describe why)
• The PR includes one or several stories (if not possible, describe why)

[fzaninotto]

Can you please add a before/after screenshot in the PR description?

[djhi]

Can you please add a before/after screenshot in the PR description?

Added

[fzaninotto]

I think the default translation should still contain the resource name:

Update post "Lorem Ipsum"

instead of

Update Lorem Ipsum

[fzaninotto]

We had a different approach with mutation success notifications: letting users provide a resource-specific translation, and defaulting to the generic one. I prefer that approach, it avoids problems with pluralization, capitalisation, etc.

notify(`resources.${resource}.notifications.created`, {
    type: 'info',
    messageArgs: {
        smart_count: 1,
        _: translate(`ra.notification.created`, {
            smart_count: 1,
        }),
    },
    undoable: mutationMode === 'undoable',
});

[djhi]

We had a different approach with mutation success notifications: letting users provide a resource-specific translation, and defaulting to the generic one. I prefer that approach, it avoids problems with pluralization, capitalisation, etc.

notify(`resources.${resource}.notifications.created`, {
    type: 'info',
    messageArgs: {
        smart_count: 1,
        _: translate(`ra.notification.created`, {
            smart_count: 1,
        }),
    },
    undoable: mutationMode === 'undoable',
});

Done