Fix <ShowGuesser> print incorrect code for reference arrays#10682
Merged
Fix <ShowGuesser> print incorrect code for reference arrays#10682
<ShowGuesser> print incorrect code for reference arrays#10682Conversation
slax57
reviewed
Apr 18, 2025
Comment on lines
+89
to
+95
| component: () => ( | ||
| <SingleFieldList> | ||
| <ChipField source="id" /> | ||
| </SingleFieldList> | ||
| ), | ||
| representation: () => | ||
| `<SingleFieldList><ChipField source="id" /></SingleFieldList>`, |
Contributor
There was a problem hiding this comment.
Can't you remove the referenceArrayChild key altogether? I'm worried the rendered JSX does not match the JSX code printed in the console.
Contributor
Author
There was a problem hiding this comment.
It might be used by guessers we don't maintain so I'd rather keep it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The console.log for reference arrays is wrong:
It should be:
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature