Conversation
slax57
commented
Apr 22, 2025
Comment on lines
+15
to
+16
| "@mui/icons-material": "^7.0.1", | ||
| "@mui/material": "^7.0.1", |
Contributor
Author
There was a problem hiding this comment.
One could argue we should also upgrade the minimum required version of react-admin to 5.8, but the latest version will be installed in any case, besides this would break the CI tests 😬
Contributor
There was a problem hiding this comment.
And it will be done by the release script ;)
djhi
approved these changes
Apr 23, 2025
create-react-admin to MUI v7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#10639 brought support for MUI v7.
To help minimizing technical debt, all new react-admin apps should start using that version right away.
But create-react-admin still uses MUI v6 by default.
Solution
Upgrade create-react-admin to generate projects that use MUI v7 by default.
How To Test
Testing with yarn
It's the easiest way to test, since we force the version of MUI packages using yarn resolutions.
make build-create-react-admin./packages/create-react-admin/node_modules/.bin/create-react-admin my-admin -icd my-adminyarn run devyarn list @mui/material) and that the app runs fineTesting with npm/pnpm/bun
It's more complex to test, because react-admin 5.7.3 still requires MUI <= 6, and react-admin 5.8.0 has not been released yet.
So you'd need to build the react-admin packages, and then force using this local version when resolving the dependencies.
To me this test adds very little to the test with yarn (basically it comes down to testing the resolution algorithm of the selected package manager).
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature- [ ] The PR includes unit tests (if not possible, describe why)- [ ] The PR includes one or several stories (if not possible, describe why)- [ ] The documentation is up to dateAlso, please make sure to read the contributing guidelines.