Fix canAccess is called even when disableAuthentication is true#10691
Merged
Fix canAccess is called even when disableAuthentication is true#10691
canAccess is called even when disableAuthentication is true#10691Conversation
djhi
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Setting
disableAuthenticationtotrueshould prevent all calls to the authProvider, i.e. calls tocheckAuthbut alsocanAccess.However in some cases, if
checkAuthwas already called earlier and the result is already in the react-query cache, a call tocanAccessmight still be fired.Solution
Fix the condition under which
canAccessis called from the controllers.How To Test
Unit tests and stories were added in this PR.
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.