create-react-admin: Remove sourcemaps from production build#10693
Merged
Conversation
djhi
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In most setups (all except
pnpm) CRA will include Vite configuration to generate sourcemaps for production builds.Most of the time this is not necessary (having the sourcemaps in development mode is enough), besides sourcemaps for the current application code (i.e. not react-admin code) are disabled in production by default (
sourcemap: mode === "development").Lastly, this setup creates issues with some package manager configurations, namely
pnpmbut also when having duplicate versions of some packages. This is for instance what's causing the CI to break here.Solution
Remove the
aliasfrom the Vite configuration.Sourcemaps are included in development mode anyways, and we still document how to have sourcemaps in production here: https://marmelab.com/react-admin/Vite.html#sourcemaps-in-production.
How To Test
make build-create-react-admin installpnpm run devuseListController.ts(Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.