Skip to content

Fix Arrayinput multiple reset#10716

Merged
slax57 merged 6 commits intomasterfrom
fix/array-input-reset
May 15, 2025
Merged

Fix Arrayinput multiple reset#10716
slax57 merged 6 commits intomasterfrom
fix/array-input-reset

Conversation

@erwanMarmelab
Copy link
Contributor

@erwanMarmelab erwanMarmelab commented Apr 30, 2025

Problem

you can’t properly reset your form (with an ArrayInput) twice.

Solution

How To Test

  1. Open https://react-admin-storybook.vercel.app/?path=/story/ra-ui-materialui-input-arrayinput--reset
  2. Add an empty line
  3. Click the reset button
  4. Add an empty line
  5. Click the reset button

or

  1. Open https://react-admin-storybook.vercel.app/?path=/story/ra-ui-materialui-input-arrayinput--reset
  2. Add an empty line
  3. fill it
  4. Click the reset button
  5. Add an empty line
  6. fill it
  7. Click the reset button

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels May 6, 2025
@erwanMarmelab
Copy link
Contributor Author

good for me 👍

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM

@slax57 slax57 modified the milestones: 4.16.21, 5.8.2 May 15, 2025
@slax57 slax57 merged commit 955bf60 into master May 15, 2025
16 checks passed
@slax57 slax57 deleted the fix/array-input-reset branch May 15, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Development

Successfully merging this pull request may close these issues.

3 participants