Skip to content

Fix <SelectArrayInput> sanitizes unused props#10739

Merged
fzaninotto merged 1 commit intomarmelab:masterfrom
ghadabezine:fix/select-array-input-typos
May 13, 2025
Merged

Fix <SelectArrayInput> sanitizes unused props#10739
fzaninotto merged 1 commit intomarmelab:masterfrom
ghadabezine:fix/select-array-input-typos

Conversation

@ghadabezine
Copy link
Contributor

This pull request removes several misspelled and unused parameters from the sanitizeRestProps function in SelectArrayInput.tsx.

Details:
The following parameters were removed:
classNamInputWithOptionsPropse
componenInputWithOptionsPropst
crudGetMInputWithOptionsPropsatching
crudGetOInputWithOptionsPropsne
These parameters do not correspond to any real props or variables and appear to be accidental copy-paste or auto-complete errors.
Cleaning these up improves code clarity and maintainability.

Checklist:
[x] Code compiles and tests pass
[x] Only unused/misspelled parameters were removed
[x] No breaking changes introduced

@fzaninotto
Copy link
Member

Whoah, that's a good one! This was introduced a long time ago in an automated refactor by @djhi in b9c25ef. I made sure no other incorrect changes were introduced at that time. It's weird that it has remained unseen until now.

Thanks for the patch!

@fzaninotto fzaninotto merged commit 6ff3f74 into marmelab:master May 13, 2025
15 checks passed
@fzaninotto fzaninotto added this to the 5.8.2 milestone May 13, 2025
@fzaninotto fzaninotto changed the title fix: remove misspelled unused parameters from sanitizeRestProps in Se… Fix <SelectArrayInput> sanitizes unused props May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants