Conversation
The current ReferenceManyCount component is tied to MUI. To reuse the same (simple) logic in other UI kits, I moved that logic to `ra-core`. ```jsx <ReferenceManyCountBase reference="comments" target="post_id" /> ```
djhi
reviewed
Jun 27, 2025
| <ErrorIcon color="error" fontSize="small" titleAccess="error" /> | ||
| ) : ( | ||
| total | ||
| const body = ( |
Contributor
There was a problem hiding this comment.
Just put it inside the main JSX directly? This body const is useless now IMO
djhi
reviewed
Jun 27, 2025
| page = 1, | ||
| pagination = null, | ||
| perPage = 25, | ||
| record, |
fzaninotto
commented
Jun 27, 2025
| >, | ||
| } = props; | ||
| const notify = useNotify(); | ||
| const record = useRecordContext(props); |
Member
Author
There was a problem hiding this comment.
This was done by callers of the hook. This logic should better be in ra-core.
| target, | ||
| queryOptions, | ||
| } = props; | ||
| const record = useRecordContext(props); |
Member
Author
There was a problem hiding this comment.
no longer necessary since the controller hook does it.
| <ErrorIcon color="error" fontSize="small" titleAccess="error" /> | ||
| ) : ( | ||
| total | ||
| const body = ( |
djhi
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current ReferenceManyCount component is tied to MUI. To reuse the same (simple) logic in other UI kits, I moved that logic to
ra-core.