[chore] Fix a failing test not showing up in useDeleteWithUndoController#10818
Merged
[chore] Fix a failing test not showing up in useDeleteWithUndoController#10818
Conversation
…useDeleteWithConfirmController.
Madeorsk
force-pushed
the
fix-delete-with-undo-failing-test
branch
from
abc51d8 to
5e4fa5b
Compare
djhi
changed the title
djhi
changed the title
djhi
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
useDeleteWithUndoControllerhad a test failing, but it wasn't showing up as the waitFor wasn't awaited.Solution
awaitthewaitForand trigger the mutation so the test can pass.How To Test
make test-unitAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature[ ] The PR includes one or several stories (if not possible, describe why)[ ] The documentation is up to date