Introduce useDeleteController

[djhi]

Problem

We currently have a lot of duplicated logic in useDeleteWithConfirmController and useDeleteWithUndoController. Besides they handle things that should only belong in the UI hooks/components (onClick, dialog handlers and state).

Solution

• Introduce useDeleteController that can be used for all mutation modes
• Use it in useDeleteWithConfirmController and useDeleteWithUndoController as we want to keep them for backward compatibility
• Use it in the DeleteWithUndoButton and DeleteWithConfirmButton
• Modify the DeleteWithConfirmButton so that it always closes the confirmation dialog before running user provided side effects

How To Test

• Buttons should work as before
• Tests should succeed as before

Additional Checks

• The PR targets master for a bugfix or a documentation fix, or next for a feature
• The PR includes unit tests (if not possible, describe why)

[Madeorsk]

Are useDeleteWithConfirmController and useDeleteWithUndoController deprecated? I'm not sure that it is a good choice as we can see that it forces UI implementation to duplicate parts of the logic (that will most likely be duplicated again in other UI kits). A good compromise could be to provide a few helpers / primitive functions with consistent side effects (like the propagation stop on click).

[Madeorsk]

It's sad to have this duplicated again. Maybe introduce a defaultOnSuccess / defaultOnError in useDeleteController so you can use them here?

[djhi]

As discussed:

1. both useDeleteWithConfirmController and useDeleteWithUndoController are deprecated
2. we don't want to export default side effects to reuse them

[Madeorsk]

This handleDelete override is exactly the same in useDeleteWithUndoController. What about doing it in useDeleteController directly? Or you want to keep useDeleteController as generic as possible so it can be used for something else than a clickable component?

[djhi]

We want to keep useDeleteController as generic as possible so it can be used for something else than a clickable component

[Madeorsk]

Using something like defaultOnSuccess / defaultOnError like my other suggestion could help to deduplicate this code.

[djhi]

As discussed, we'll keep the duplication