Add warning when using queryOptions to add a meta in <Edit> and <EditBase>#10882
Merged
fzaninotto merged 5 commits intomasterfrom Aug 12, 2025
Merged
Add warning when using queryOptions to add a meta in <Edit> and <EditBase>#10882fzaninotto merged 5 commits intomasterfrom
queryOptions to add a meta in <Edit> and <EditBase>#10882fzaninotto merged 5 commits intomasterfrom
Conversation
…ptions without redirecting.
fzaninotto
requested changes
Aug 12, 2025
| const dataProvider = { getOne } as unknown as DataProvider; | ||
|
|
||
| render( | ||
| <CoreAdminContext dataProvider={dataProvider}> |
Member
There was a problem hiding this comment.
I wonder why you don't use your story here. This would avoid duplication.
fzaninotto
approved these changes
Aug 12, 2025
queryOptions to add a meta in <Edit> and <EditBase>`
queryOptions to add a meta in <Edit> and <EditBase>`queryOptions to add a meta in <Edit> and <EditBase>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When providing a meta in the
queryOptionof an<Edit>, users must also provide it to the samemutationOptions. Otherwise, when disabling the redirection to the list, they might end up with the data not being updated correctly.Solution
One issue with the warning: it will be shown if users have a custom
onSuccesswhere they redirect, but haveredirect={false}.How To Test
Story
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature