Add offline support to <ListBase> and <List>#10896
Merged
Conversation
Madeorsk
requested changes
Aug 28, 2025
| isAuthPending && | ||
| !disableAuthentication && | ||
| loading !== undefined && | ||
| loading !== false; |
Contributor
There was a problem hiding this comment.
Before this change, the content was never shown when isAuthPending was true. Now, it can be. I know we did the same with ShowBase and EditBase, but I wanted to be sure that it is done on purpose: if someone provided null to hide the content while authentication is pending, it will now show the content instead of hiding it.
Contributor
Author
There was a problem hiding this comment.
I actually realize I introduced the same regression in EditBase and ShowBase... PR imcoming. Regarding your comment, you're right and that's what we decided with @fzaninotto. Might be worth to discuss it again before releasing.
Madeorsk
reviewed
Sep 1, 2025
Madeorsk
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Our components and hooks can't leverage the offline support provided by Tanstack Query.
Solution
ra-ui-materialuiHow To Test
<ListBase><List>Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.