-
Notifications
You must be signed in to change notification settings - Fork 10
chore(Cargo): bump rust-nostr to version 0.44 #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughReplaced uses of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Coverage: 88.74% → 90.71% (+1.97%) |
d853459 to
14ddf55
Compare
✅ Coverage: 88.74% → 90.71% (+1.97%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@crates/mdk-core/CHANGELOG.md`:
- Line 28: The CHANGELOG entry about upgrading the `nostr` dependency needs a PR
link appended; update the entry string ("Upgraded `nostr` dependency from 0.43
to 0.44, replacing deprecated `Timestamp::as_u64()` calls with
`Timestamp::as_secs()`") to include the PR reference in the required format
`([`#123`](https://github.com/marmot-protocol/mdk/pull/123))`, replacing 123 with
the actual PR number.
In `@crates/mdk-sqlite-storage/CHANGELOG.md`:
- Line 32: The changelog entry about upgrading the nostr dependency is missing
the required PR link; update the line mentioning "Upgraded `nostr` dependency
from 0.43 to 0.44, replacing deprecated `Timestamp::as_u64()` calls with
`Timestamp::as_secs()`" to append the PR reference in the standard format (e.g.,
add " (PR #<number>)" or the full PR URL) at the end of that entry so it
complies with CHANGELOG guidelines.
In `@crates/mdk-uniffi/CHANGELOG.md`:
- Line 34: The changelog entry mentioning the nostr dependency upgrade and
replacement of Timestamp::as_u64() with Timestamp::as_secs() is missing the
required PR link; update the entry in CHANGELOG.md (the line referencing "nostr"
and the method names Timestamp::as_u64() -> Timestamp::as_secs()) by appending
the corresponding PR URL (e.g., " (`#1234`)" or full link) to the end of the
sentence so it complies with the project's changelog guidelines.
14ddf55 to
1f39347
Compare
✅ Coverage: 88.74% → 90.71% (+1.97%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/mdk-uniffi/CHANGELOG.md (1)
32-41: Remove the duplicate empty### Changedsection.Two
### Changedheadings under## Unreleasedcreates ambiguity and breaks the changelog structure. Keep a single### Changedsection. As per coding guidelines, Keep a Changelog structure should be consistent.🧹 Proposed fix
@@ ### Changed - Upgraded `nostr` dependency from 0.43 to 0.44, replacing deprecated `Timestamp::as_u64()` calls with `Timestamp::as_secs()` ([`#162`](https://github.com/marmot-protocol/mdk/pull/162)) - Changed `get_messages()` to accept optional `limit` and `offset` parameters for pagination control. Existing calls must be updated to pass `None, None` for default behavior (limit: 1000, offset: 0), or specify values for custom pagination. ([`#111`](https://github.com/marmot-protocol/mdk/pull/111)) - Changed `get_pending_welcomes()` to accept optional `limit` and `offset` parameters for pagination control. Existing calls must be updated to pass `None, None` for default behavior (limit: 1000, offset: 0), or specify values for custom pagination. ([`#119`](https://github.com/marmot-protocol/mdk/pull/119)) - Changed `new_mdk()`, `new_mdk_with_key()`, and `new_mdk_unencrypted()` to accept an optional `MdkConfig` parameter for customizing MDK behavior. Existing calls must be updated to pass `None` for default behavior. ([`#155`](https://github.com/marmot-protocol/mdk/pull/155)) - -### Changed
1f39347 to
196eafc
Compare
✅ Coverage: 88.74% → 90.71% (+1.97%) |
This PR upgrades the workspace dependency
nostrfrom 0.43 to 0.44 and updates timestamp usage across the codebase to the new Timestamp API, replacing deprecatedTimestamp::as_u64()calls withTimestamp::as_secs()to use seconds-based representations. The change is an internal refactor of timestamp handling and storage serialization with no changes to public APIs or behavioral logic beyond timestamp units.What changed:
Timestamp::as_u64()usages withas_secs()in message validation, timestamp comparisons, epoch snapshot code, error messages, and related tests.as_secs()when persisting timestamps to the database.as_secs().as_secs()where applicable.as_u64()toas_secs().Security impact:
Protocol changes:
API surface:
Testing: