Skip to content

separate rerank count tests into structured and unstructured#277

Merged
vicilliar merged 1 commit intomainlinefrom
joshua/separate-rerank-count-tests
Mar 18, 2025
Merged

separate rerank count tests into structured and unstructured#277
vicilliar merged 1 commit intomainlinefrom
joshua/separate-rerank-count-tests

Conversation

@vicilliar
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    tensor_fields=None for unstructured index

  • What is the new behavior (if this is a feature change)?
    split rerank count test into unstructured and structured tests to avoid tensor_fields=None issue

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@vicilliar vicilliar merged commit b8659b1 into mainline Mar 18, 2025
25 of 26 checks passed
@vicilliar vicilliar deleted the joshua/separate-rerank-count-tests branch March 18, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants