Skip to content

Add allow_missing_documents and allow_missing_embeddings to recommend#299

Merged
wanliAlex merged 3 commits intomainlinefrom
li/add-parameters-to-recommend
Aug 21, 2025
Merged

Add allow_missing_documents and allow_missing_embeddings to recommend#299
wanliAlex merged 3 commits intomainlinefrom
li/add-parameters-to-recommend

Conversation

@wanliAlex
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add allow_missing_documents and allow_missing_embeddings to recommend

Copy link
Collaborator

@papa99do papa99do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't need to add to search context? Is it because it's a dict?

@wanliAlex wanliAlex changed the base branch from releases/3.16 to mainline August 21, 2025 05:28
@wanliAlex wanliAlex requested a review from papa99do August 21, 2025 05:34
@wanliAlex wanliAlex merged commit 1a88b12 into mainline Aug 21, 2025
31 of 47 checks passed
@wanliAlex wanliAlex deleted the li/add-parameters-to-recommend branch August 21, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants