Skip to content

Delete no model tests#301

Merged
wanliAlex merged 3 commits intomainlinefrom
li/fix-no-model
Mar 5, 2026
Merged

Delete no model tests#301
wanliAlex merged 3 commits intomainlinefrom
li/fix-no-model

Conversation

@wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Mar 4, 2026

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Delete no model tests as they are not supported in the Triton release

Note

Low Risk
Low functional risk since this only removes test coverage and test-index fixtures for the unsupported no_model setup. The main risk is reduced regression coverage if no_model support returns or was still relied on in some environments.

Overview
Removes the no_model-based test index from cloud test fixtures by deleting CloudTestIndex.unstructured_no_model and its settings mapping.

Updates the shared MarqoTestCase test-index setup to stop creating/using the unstructured no_model index, and deletes the test_no_model_custom_vector_doc coverage in test_add_documents.py.

Written by Cursor Bugbot for commit 07e484e. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

ommirzaei
ommirzaei previously approved these changes Mar 4, 2026
@wanliAlex wanliAlex requested a review from ommirzaei March 5, 2026 01:54
@wanliAlex wanliAlex merged commit 7845d98 into mainline Mar 5, 2026
7 of 11 checks passed
@wanliAlex wanliAlex deleted the li/fix-no-model branch March 5, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants