Skip to content

Fix eject model tests for Triton#303

Merged
wanliAlex merged 1 commit intomainlinefrom
li/fix-eject-model-tests
Mar 10, 2026
Merged

Fix eject model tests for Triton#303
wanliAlex merged 1 commit intomainlinefrom
li/fix-eject-model-tests

Conversation

@wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Mar 10, 2026

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix eject model tests for Triton

Note

Low Risk
Test-only changes that update assertions for eject_model behavior and messages; low risk aside from potentially masking real API regressions if the new success-on-miss behavior is unintended.

Overview
Updates test_model_cache_management to align with Triton/model-cache behavior: switches the default OpenCLIP model used in tests, treats ejection of a non-cached model as a successful no-op (instead of raising MarqoWebError), and loosens/normalizes success message assertions to match the current response text.

Written by Cursor Bugbot for commit 8c3a103. This will update automatically on new commits. Configure here.

@wanliAlex wanliAlex merged commit 8405555 into mainline Mar 10, 2026
13 of 29 checks passed
@wanliAlex wanliAlex deleted the li/fix-eject-model-tests branch March 10, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants