Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the fallback logic for the public Pyth Hermes endpoint to improve error handling during API calls. Key changes include:
- Introducing a local variable to store the API response.
- Implementing nested try blocks to separately handle primary and fallback API calls.
- Changing the outer error handling to return an empty price array instead of throwing the exception.
Comments suppressed due to low confidence (1)
src/api/prices/getPythPrices.ts:45
- [nitpick] If 'priceFeedIds' is always a one-dimensional array, the use of .flat() may be redundant and could be removed to improve clarity.
pythPrices/${priceFeedIds.flat().join('-')}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the fallback logic for fetching Pyth prices from the public Pyth Hermes endpoint. Key changes include:
- Wrapping the primary API fetch call in its own try block.
- Adding a fallback fetch with proper error logging.
- Returning an empty array in case both API calls fail.
Patricie29
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes