Conversation
…oduce keeper fee hook to avoid code duploicarion
… conditional triggers section
…update order submission parameters
…rs during limit order submission
…ate conditional triggers in order submission both for marketand limit orders
… enhance order management with child order handling
…mponents; improve max value calculations for USD and asset amounts
…triggers button; add isUSD prop to SwapForm component
…r filtering and amount handling
…ext for amount type selection in PerpsModule
…ount handling in NumberInput and usePerpsCallbacks
… code readability and consistency
…r for improved conditional rendering
…prove title rendering
…remove warning for existing orders in conditional modal
- Introduced `buildParentChildMapping` and `getPositionSLTPIndicators` utility functions to streamline the management of stop loss and take profit indicators. - Updated `Size` component to accept a `type` prop for better value scaling based on order type. - Refactored `Status` component to utilize the new SL/TP indicators logic. - Adjusted `usePerpsBalancesColumns` to integrate the new mapping and indicators. - Modified `PerpsModule` to conditionally render `KeeperFee` based on SL/TP triggers. - Updated broadcast slice to correctly shift price values based on asset decimals. - Enhanced type definitions for better clarity and maintainability.
…alances tables - Modified the `Size` component in `useAccountPerpsColumns` and `usePerpsBalancesColumns` to accept a `type` prop for improved value representation based on order type. - Removed unused `usePerpsLimitOrderRows` import in `usePerpsBalancesColumns` for cleaner code.
Fix simulation
- Updated limit price calculations for stop loss and take profit to account for PRICE_ORACLE_DECIMALS. - Removed redundant onClose() call from the handleDone function for cleaner execution flow.
refactor: adjust limit price calculations in PerpsSlTpModal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StefChatz
approved these changes
Jul 29, 2025
Patricie29
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapping
Vaults
Borrow
Perps
HLS
Common