fix: useFind default typing broken#173
Open
mrfrase3 wants to merge 1 commit intomarshallswain:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just pulled my hair out comparing the setup from project A to project B, where the data field returned from useFind in project B was not inferring the service type, and instead insisting on unknown[], finally looked at the package versions, long behold project B is running on the latest and A in on 4.4.0 😅
looks like this is the culprit: 4804ef4
if you don't explicitly provide a type for M, it assumes it's unknown. I managed to fix it by setting a default on the declaration <M = SvcModel>
Also taking out the ambiguity of the type, either its the override or the default type, not both