Skip to content

Conversation

@NickNevzorov
Copy link

https://zeoslib.sourceforge.io/viewtopic.php?t=225651

image

I can't imagine how else this problem can be solved without rewriting the PreparedStatement interface (adding the ability to transfer a transaction when creating it) and all other depend classes.

Patch for ZAbstractRODataset.pas is not clear, but it is a fastest way to send transaction to PreparedStatement.

Maybe you have better ideas?

@marsupilami79
Copy link
Owner

Hello Nick,

I aked the EgonHugeist who is currently working on this problem to review your patch. He told me that he thinks that your approach is interesting but he has to read up on some documentatation. Also - the same as you - he doesn't like the special treatment of the TZInterbase6PreparedStatement in ZAbstractRODataset.pas. ZAbstractRODataset.pas should be generic. I have to agree with the ZAbstractRODataset.pas being generic. Drivers should behave the same because all drivers should adhere to the same DBC layer driver interface specification. The DBC layer mostly derives from JDBC.

I will have another talk with EgonHugeist on wednesday. I have to ask you to be patient with us.

Best regards,

Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants