Skip to content

chore: little things#207

Merged
martimlobao merged 1 commit intomainfrom
chore/little-things
Jan 28, 2026
Merged

chore: little things#207
martimlobao merged 1 commit intomainfrom
chore/little-things

Conversation

@martimlobao
Copy link
Owner

@martimlobao martimlobao commented Jan 28, 2026

  • don't stash existing changes by default when running bootstrap script
  • add exportenv function to export env variables from .env (not the same as 'source .env')
  • remove unsupported cursor extension

Note

Adjusts bootstrap behavior and adds a small utility.

  • bootstrap.sh: replace -d with -c flag and switch logic to stash only when -c is passed (DIRTY -> CLEAN)
  • linkme/.functions: add exportenv to export variables from a .env file
  • linkme/.config/code/extensions.txt: remove grapecity.gc-excelviewer

Written by Cursor Bugbot for commit eca735c. This will update automatically on new commits. Configure here.

- don't stash existing changes by default when running bootstrap script
- add exportenv function to export env variables from .env (not the same as 'source .env')
- remove unsupported cursor extension
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the bootstrap script to avoid stashing local changes by default, adds a helper function for exporting variables from .env, and removes an unsupported VS Code Cursor extension from the tracked extensions list.

File-Level Changes

Change Details Files
Change bootstrap script semantics so that stashing local changes is opt‑in instead of default.
  • Rename DIRTY flag to CLEAN and invert its meaning to represent an explicit request to work from a clean tree.
  • Change command-line option from -d to -c to control whether existing git changes are stashed before proceeding.
  • Guard the git stash operation on CLEAN being true instead of the previous DIRTY==false behavior, so stashing only occurs when explicitly requested.
bootstrap.sh
Maintain VS Code extension list by removing an unsupported Cursor extension.
  • Delete the entry for the unsupported Cursor extension from the extensions manifest used by the linkme setup.
linkme/.config/code/extensions.txt
Add a shell helper to export environment variables from a .env file without sourcing it directly.
  • Introduce an exportenv function that reads a .env file and exports its key/value pairs into the current shell environment.
  • Ensure behavior is distinct from directly running source .env, avoiding side effects like executing arbitrary shell code.
linkme/.functions

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Changing the bootstrap flag from -d (DIRTY) to -c (CLEAN) and inverting the default behavior is a breaking change for any existing scripts or habits; consider either supporting both flags temporarily or adding a clear deprecation path/usage message so callers don’t get surprising behavior.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Changing the bootstrap flag from `-d` (DIRTY) to `-c` (CLEAN) and inverting the default behavior is a breaking change for any existing scripts or habits; consider either supporting both flags temporarily or adding a clear deprecation path/usage message so callers don’t get surprising behavior.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit 52693a4 into main Jan 28, 2026
19 checks passed
@martimlobao martimlobao deleted the chore/little-things branch January 28, 2026 01:51
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

# Export environment variables from .env file (TIL this is not the same as `source .env`)
function exportenv() {
export $(grep -v '^#' "${1:-".env"}" | xargs)
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Word splitting corrupts env vars with spaces

Low Severity

The exportenv function uses an unquoted command substitution export $(...) which causes bash word splitting on the output. When .env files contain values with spaces (e.g., MESSAGE="Hello World"), the value gets split incorrectly, resulting in malformed variable assignments. The function will silently set wrong values or fail for common .env patterns.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant