fix blank replacement on relabel matches fixes #363#391
Open
crystalstorm wants to merge 1 commit intomartin-helmich:masterfrom
Open
fix blank replacement on relabel matches fixes #363#391crystalstorm wants to merge 1 commit intomartin-helmich:masterfrom
crystalstorm wants to merge 1 commit intomartin-helmich:masterfrom
Conversation
|
Code Climate has analyzed commit 93469d5 and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the relabeling issues reported here #363 and here #377
The current logic is flawed, because in the case where there are Matches but the Regexp does NOT match the sourceValue
the sourceValue still gets replaced with ""