Skip to content

Fail benchmarks if any errors #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025
Merged

Fail benchmarks if any errors #384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
776af48
Fail benchmarks if any errors
martincostello Jul 26, 2025
71c235e
Fix compilation
martincostello Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions benchmark.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,8 @@ if (-Not [string]::IsNullOrEmpty(${env:GITHUB_SHA})) {
}

& $dotnet run --project $benchmarks --configuration "Release" -- $additionalArgs

if ($LASTEXITCODE -ne 0) {
Write-Error "Benchmarks failed with exit code $LASTEXITCODE."
exit $LASTEXITCODE
}
3 changes: 2 additions & 1 deletion perf/TodoApp.Benchmarks/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@
}
else
{
BenchmarkRunner.Run<OpenApiBenchmarks>(args: args);
var summary = BenchmarkRunner.Run<OpenApiBenchmarks>(args: args);
return summary.Reports.Any((p) => !p.Success) ? 1 : 0;
}
Loading