Add a broken test to simulate libinputs sys-path and device path validation#49
Draft
APokorny wants to merge 1 commit intomartinpitt:mainfrom
Draft
Add a broken test to simulate libinputs sys-path and device path validation#49APokorny wants to merge 1 commit intomartinpitt:mainfrom
APokorny wants to merge 1 commit intomartinpitt:mainfrom
Conversation
When libinput is asked to open a device via path it opens the device directly but also tries to achieve the same by evaluating major minor from fstat(fd).st_rdev and opening the resulting /sys/dev/type/major:mior path. The information returned by fstat does currently not match the stat data received directly from the path.
|
👍 |
martinpitt
force-pushed
the
master
branch
2 times, most recently
from
4fc5ae4 to
6e9d9f1
Compare
martinpitt
force-pushed
the
master
branch
4 times, most recently
from
b0d18da to
5b9b776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When libinput is asked to open a device via path it opens the device
directly but also tries to achieve the same by evaluating major minor
from fstat(fd).st_rdev and opening the resulting
/sys/dev/type/major:mior path. The information returned by fstat does
currently not match the stat data received directly from the path.
I tried to get this working without needing the file, but failed to setup the umockdev device properly.
With the given test it bails out, just like libinput would:
ERROR:tests/test-umockdev.c:302:t_testbed_add_devicev_fstat: assertion failed (stat_from_stat.st_rdev == stat_from_fstat.st_rdev): (3398 == 34850)