Support defining nested objects in lexicons#55
Open
LemmaEOF wants to merge 1 commit intomary-ext:trunkfrom
Open
Support defining nested objects in lexicons#55LemmaEOF wants to merge 1 commit intomary-ext:trunkfrom
LemmaEOF wants to merge 1 commit intomary-ext:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, atcute rejects direct-nested objects in Lexicon type definitions. However, the typescript reference implementation, the go reference implementation, and honk support it, and while the Lexicon spec defines objects as "A generic object schema which can be nested inside other definitions by reference", it does not outright forbid nesting inline objects like it specifies that
unions must be objects.Pending a proper clarification, this PR brings atcute in line with the other validator implementations and supports direct inlining of object definitions.