Tweaked apogee detection autosequence and added orientation determination- Autosequence dev#13
Open
swalther06 wants to merge 13 commits intomainfrom
Open
Tweaked apogee detection autosequence and added orientation determination- Autosequence dev#13swalther06 wants to merge 13 commits intomainfrom
swalther06 wants to merge 13 commits intomainfrom
Conversation
felixcreate
requested changes
Jan 9, 2026
Contributor
felixcreate
left a comment
There was a problem hiding this comment.
Just a couple requests/comments, looks great though!
| if (detect_MECO(&imu_detector) || getTime() - ignition_timestamp > MAX_MECO_WAIT) | ||
| { | ||
| MECO_flag = 1; | ||
| meco_timestamp = xTaskGetTickCount(); |
Contributor
There was a problem hiding this comment.
I think you should keep the time source consistent, e.g. above you used getTime(). I support abstracting it for now and using getTime().
…eration, velocity, and altitude post-lockout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created flight-autosequence folder. moved parts of apogee detection to flight autosequence file and made complementary filter (gyro + imu) for orientation. added vertical velocity determination post-lockout in autosequence file