Open
Conversation
ryw27
commented
Mar 12, 2026
src/limewire/limewire.py
Outdated
Comment on lines
+461
to
+465
| try: | ||
| send_ntp_sync(logger) | ||
| except Exception: | ||
| # send_ntp_sync already logs; we just want to avoid crashing the task | ||
| pass |
Contributor
Author
There was a problem hiding this comment.
I don't think we need to avoid crashing the task, here. In general, I would like to try to avoid very broad try catch blocks, and most of the other send_ntp_syncs don't use a try catch block.
src/limewire/limewire.py
Outdated
| except Exception: | ||
| # send_ntp_sync already logs; we just want to avoid crashing the task | ||
| pass | ||
| await asyncio.sleep(60) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.