feat(compiler): make supported_platforms a universal source field#2002
feat(compiler): make supported_platforms a universal source field#2002williamboman merged 1 commit intomainfrom
supported_platforms a universal source field#2002Conversation
Previously this field had to be handled separately in each source type. This backwards-compatible change makes `supported_platforms` a universal top-level field on the `source:` object, meaning it'll be parsed for each source type.
|
While you are at it: this PR revealed a tangentially related problem, regarding support for less popular platforms (freebsd), in case it's an easy fix that you can just tack on? |
I think for that issue we would just have to setup CI tests on the mason-registry side mainly and adjust the enum of platforms and targets. Idk about the side of mason.nvim itself though. |
I don't have access to a FreeBSD system so I can't really test and verify how to best do the platform detection. It's probably sufficient to rely on libuv's
Ultimately it'd have to be implemented in the mason.nvim client as well. The registry and the client are decoupled, we could "easily" add FreeBSD support to the registry, then it's just a matter for the client to recognize that platform. |
…ason-org#2002) Previously this field had to be handled separately in each source type. This backwards-compatible change makes `supported_platforms` a universal top-level field on the `source:` object, meaning it'll be parsed for each source type.
…ason-org#2002) Previously this field had to be handled separately in each source type. This backwards-compatible change makes `supported_platforms` a universal top-level field on the `source:` object, meaning it'll be parsed for each source type.
Previously this field had to be handled separately in each source type
(currently only supported by
cargo,gem,pypi). Thisbackwards-compatible change makes
supported_platformsa universaltop-level field on the
source:object, meaning it'll be parsed foreach source type.
PR to modify the schema: mason-org/registry-schema#17.