add noBanner metadata for the site no to display the deweb banner#337
Open
add noBanner metadata for the site no to display the deweb banner#337
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to conditionally hide the deweb banner based on server configuration. The main purpose is to allow sites to disable the banner display through a new noBanner configuration option.
- Added
noBannerboolean field to server configuration with YAML support - Updated API model and OpenAPI specification to include the new field
- Modified client-side JavaScript to check server response before displaying banner
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/int/api/config/config.go | Added NoBanner boolean field to configuration structs and default config |
| server/int/api/handlers.go | Added NoBanner field to API response payload |
| server/int/api/resources/massaBox.html | Updated banner display logic to fetch server config and conditionally show banner |
| server/api/readAPI-V0.yml | Added noBanner boolean field to OpenAPI specification |
| server/api/read/restapi/embedded_spec.go | Updated embedded OpenAPI spec with noBanner field |
| server/api/read/models/de_web_info.go | Added NoBanner field to Go model struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
peterjah
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.