Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes network name detection by standardizing the chainID/chainId field naming and updating the network type detection logic to use the @massalabs/massa-web3 library.
Changes:
- Renamed
chainIDtochainIdin TypeScript interface for consistency with JavaScript naming conventions - Refactored network type detection logic to use
getNetworkNameByChainIdfrom@massalabs/massa-web3 - Added
@massalabs/massa-web3as a dependency
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/home/src/types/server.ts | Changed field name from chainID to chainId in NetworkInfo interface |
| plugin/home/src/Status.tsx | Refactored network detection logic to use massa-web3 library and updated to use chainId |
| plugin/home/src/App.tsx | Updated chain ID field reference in network comparison logic |
| plugin/home/package.json | Added @massalabs/massa-web3 dependency |
| plugin/home/package-lock.json | Added package lock entries for new dependency and its transitive dependencies |
Files not reviewed (1)
- plugin/home/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cc2502a to
67c85b1
Compare
fleandrei
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.