This repository was archived by the owner on Jun 26, 2018. It is now read-only.
toggle js-location-listing class at layout breakpoint#631
Open
clairesunstudio wants to merge 6 commits intodevfrom
Open
toggle js-location-listing class at layout breakpoint#631clairesunstudio wants to merge 6 commits intodevfrom
clairesunstudio wants to merge 6 commits intodevfrom
Conversation
hackajesse
reviewed
Nov 6, 2017
Contributor
hackajesse
left a comment
There was a problem hiding this comment.
Passes external review, but needs a changelog @clairesunstudio. Moving to WIP so you can do that. Once you do, move directly to Internal Review for @isaacchansky.
Contributor
|
Sorry for the super delayed review on this. I think a simpler way to do this might be to just bind the click/mouseover/etc events once, and check the screen-width upon interaction to either do nothing or continue as normal. Rough code would look like: This would avoid the binding/unbinding issues, and simply bind once. |
isaacchansky
suggested changes
Nov 27, 2017
Contributor
isaacchansky
left a comment
There was a problem hiding this comment.
See previous comment, happy to chat about this on Monday!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable the scroll up to map on mobile on location listing- this feels very jarring, and also does not add any additional info.
Related Issue / Ticket
Steps to Test
Screenshots
Additional Notes:
Help needed:
when resize down to window size < 911px, map doesn't recenter.
Impacted Areas in Application
@todo
Today I learned...