scratchpad3d: Fix leaks of heap-allocated CBaseCommand children deleted by base pointer

dimhotepus · mastercoms · commit d17631a8dfcf · 2025-02-22T20:10:33.000-05:00
Closes ValveSoftware#745
diff --git a/src/public/scratchpad3d.h b/src/public/scratchpad3d.h
@@ -51,7 +51,7 @@ class CScratchPad3D : public IScratchPad3D
 							m_pCachedRenderData = NULL;
 						}
 
-						~CBaseCommand()
+						virtual ~CBaseCommand()
 						{
 							ReleaseCachedRenderData();
 						}

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ class CScratchPad3D : public IScratchPad3D`
`51`	`51`	`m_pCachedRenderData = NULL;`
`52`	`52`	`}`
`53`	`53`
`54`		`- ~CBaseCommand()`
	`54`	`+ virtual ~CBaseCommand()`
`55`	`55`	`{`
`56`	`56`	`ReleaseCachedRenderData();`
`57`	`57`	`}`