Skip to content

feat: add linter configs to the os sync task #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonplatter merged 3 commits into from
Jun 13, 2025
Merged

feat: add linter configs to the os sync task #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b45e8d
feat: https://github.com/masterpointio/terraform-module-template/pull…
westonplatter Jun 13, 2025
b06e7ed
fix: bring modules list back
westonplatter Jun 13, 2025
c8d4ce0
feat: order sync files a-z
westonplatter Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
.cursor/rules/*
.cursor/rules/*

# Claude Code - we beleive engineers are responsible for the code they push no matter how it's generated.
# Therefore, configs specific to their coding practices are their responsibilty to judiciously manage.
.claude/*

12 changes: 8 additions & 4 deletions lib/os-modules/Taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ vars:
terraform-aws-ssm-agent \
terraform-aws-tailscale \
terraform-datadog-users \
terraform-github-teams \
Copy link
Member Author

@westonplatter westonplatter Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ordering modules in a-z order

terraform-github-organization \
terraform-github-teams \
terraform-googleworkspace-users-groups-automation \
terraform-postgres-config-dbs-users-roles \
terraform-secrets-helper \
Expand All @@ -32,12 +32,16 @@ tasks:
vars:
MODULES: "{{if .CLI_ARGS}}{{.CLI_ARGS}}{{else}}{{.DEFAULT_MODULES}}{{end}}"
FILES: >-
.github
.trunk
.checkov.yaml
Copy link
Member Author

@westonplatter westonplatter Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and ordering a-z

.coderabbit.yaml
.editorconfig
.gitignore
.github
.markdownlint.yaml
.terraform-docs.yaml
.tflint.hcl
.trunk
.yamllint.yaml
LICENSE
aqua.yaml
cmds:
Expand All @@ -46,7 +50,7 @@ tasks:
modules=$(echo "{{.MODULES}}" | tr '\n' ' ' | sed 's/\\//g')
for module in $modules
do
echo "Syncing files to ../$module..."
echo "Syncing files to ../$module ..."
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Harden the sync script with strict error handling

Add set -euo pipefail at the top of the sync task’s inline script so that any error aborts the task immediately:

     cmds:
-      - |
+      - |
+        set -euo pipefail
         # Convert newlines to spaces and remove backslashes
         modules=$(echo "{{.MODULES}}" | tr '\n' ' ' | sed 's/\\//g')
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
echo "Syncing files to ../$module ..."
cmds:
- |
set -euo pipefail
# Convert newlines to spaces and remove backslashes
modules=$(echo "{{.MODULES}}" | tr '\n' ' ' | sed 's/\\//g')
🤖 Prompt for AI Agents 
In lib/os-modules/Taskfile.yaml at line 42, the sync task's inline script lacks
strict error handling. Add the line `set -euo pipefail` at the very beginning of
the script to ensure the task aborts immediately on any error, undefined
variable, or failed pipeline command.

for file in {{.FILES}}
do
echo " Syncing $file"
Expand Down