-
Notifications
You must be signed in to change notification settings - Fork 2
feat: GHA, trunk and renovate updates #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update modifies three files related to repository automation and dependency management. The Renovate configuration is enhanced to support the "github-actions" manager, introduces new package rules for both GitHub Actions and Terraform dependencies, and reorganizes global settings for clarity. The main testing workflow is simplified by replacing multiple explicit steps with a single composite action that handles Terraform testing and AWS credential management internally. Additionally, the trunk upgrade workflow is updated to assign an ID to the upgrade step and adds a new step that automatically merges upgrade pull requests using the GitHub CLI when applicable. Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/renovate.json5 (1)
19-21: Add monthly update schedule
Running Renovate "after 9 am on the first day of the month" reduces noise; consider specifying a"timezone"if you need a particular time zone for consistency..github/workflows/trunk-upgrade.yaml (1)
37-43: Auto-merge PRs using GitHub CLI
This step conditionally auto-merges upgrade PRs. Ensure the pre-installedghCLI onubuntu-latestsupports the--autoand--delete-branchflags, and verify branch protection settings allow deletion. Consider adding--repo ${{ github.repository }}for explicit context..github/workflows/test.yaml (1)
24-28: Use composite action for TF tests
Switching tomasterpointio/github-action-tf-test@...greatly simplifies the workflow. Ensure this action includes repository checkout and AWS OIDC setup, and verify its inputs (tf_type,aws_role_arn,github_token) match the action’s documented parameters.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/renovate.json5(2 hunks).github/workflows/test.yaml(1 hunks).github/workflows/trunk-upgrade.yaml(1 hunks)
🔇 Additional comments (9)
.github/renovate.json5 (8)
7-8: Enable GitHub Actions manager for Renovate
Adding"github-actions"alongside"terraform"ensures Renovate will detect and manage GH Actions workflow updates.
22-24: Auto-assign code owners and dashboard cleanup
EnablingassigneesFromCodeOwnersanddependencyDashboardAutoclosestreamlines review and maintenance. The dynamic label{{manager}}is a nice touch—ensure Renovate supports this templating inaddLabels.
27-33: Auto-merge minor/patch/pin/digest GH Actions updates
Automatically merging low-impact GitHub Actions updates reduces manual effort. Confirm thatautomergeType: "branch"aligns with your workflow requirements.
35-39: Group major GH Actions updates for review
Keeping major changes under"github-actions-needs-review"with theneeds-reviewlabel ensures they receive proper oversight.
41-44: Group all Terraform manager updates for review
Using a"tf"group with aneeds-reviewlabel on all Terraform updates is consistent with your manual review policy.
48-49: Configure OpenTofu registry for Terraform providers/modules
Pointing datasources tohttps://registry.opentofu.orgcorrectly directs Renovate to your OpenTofu-based modules and providers.
54-55: Configure OpenTofu registry for required_version in .tofu files
This ensures module version constraints in.tofufiles reference the correct OpenTofu registry.
60-61: Configure Terraform registry for required_version in .tf files
Usinghttps://registry.terraform.ioaligns required version checks with HashiCorp’s public registry..github/workflows/trunk-upgrade.yaml (1)
30-30: Expose upgrade outputs with an ID
Addingid: trunk-upgradelets you referencepull-request-numberin later steps—great enhancement.
Gowiem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2025-05-07) ### Features * GHA, trunk and renovate updates ([#34](#34)) ([b16fa86](b16fa86)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
what
Renovate updates:
Test GHA updates:
Trunk Upgrade updates:
--autoenables auto-merge, waiting until all required checks have passed.contents: write,pull-requests: writewhy
references
Summary by CodeRabbit