Skip to content

Conversation

@gberenice
Copy link
Member

@gberenice gberenice commented May 6, 2025

what

  • Renovate updates:

    • Added github-actions manager
    • Grouped TF and GHA updates to reduce noise (see the docs)
    • Configured to merge minor GHA updates automatically
    • TF and major GHA updates require review
  • Test GHA updates:

    • Switched to reusable GHA
  • Trunk Upgrade updates:

    • Added a step to merge the PR automatically with a native GH tooling (see the recommendations from community).
    • GitHub CLI (gh) is pre-installed on ubuntu-latest.
    • --auto enables auto-merge, waiting until all required checks have passed.
    • GitHub App already has appropriate permissions: contents: write, pull-requests: write

why

  • This is a desired behaviour.

references

Summary by CodeRabbit

  • Chores
    • Updated dependency management configuration to improve automation for GitHub Actions and Terraform updates, including enhanced grouping and labeling of update PRs.
    • Simplified the test workflow by consolidating multiple steps into a single action for Terraform and Tofu testing.
    • Enhanced the trunk upgrade workflow to automatically merge upgrade pull requests when applicable.

@gberenice gberenice requested a review from a team as a code owner May 6, 2025 14:58
@coderabbitai
Copy link

coderabbitai bot commented May 6, 2025

Walkthrough

This update modifies three files related to repository automation and dependency management. The Renovate configuration is enhanced to support the "github-actions" manager, introduces new package rules for both GitHub Actions and Terraform dependencies, and reorganizes global settings for clarity. The main testing workflow is simplified by replacing multiple explicit steps with a single composite action that handles Terraform testing and AWS credential management internally. Additionally, the trunk upgrade workflow is updated to assign an ID to the upgrade step and adds a new step that automatically merges upgrade pull requests using the GitHub CLI when applicable.

Possibly related PRs

Suggested reviewers

  • Gowiem

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
.github/renovate.json5 (1)

19-21: Add monthly update schedule
Running Renovate "after 9 am on the first day of the month" reduces noise; consider specifying a "timezone" if you need a particular time zone for consistency.

.github/workflows/trunk-upgrade.yaml (1)

37-43: Auto-merge PRs using GitHub CLI
This step conditionally auto-merges upgrade PRs. Ensure the pre-installed gh CLI on ubuntu-latest supports the --auto and --delete-branch flags, and verify branch protection settings allow deletion. Consider adding --repo ${{ github.repository }} for explicit context.

.github/workflows/test.yaml (1)

24-28: Use composite action for TF tests
Switching to masterpointio/github-action-tf-test@... greatly simplifies the workflow. Ensure this action includes repository checkout and AWS OIDC setup, and verify its inputs (tf_type, aws_role_arn, github_token) match the action’s documented parameters.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1086f94 and e7327c9.

📒 Files selected for processing (3)
  • .github/renovate.json5 (2 hunks)
  • .github/workflows/test.yaml (1 hunks)
  • .github/workflows/trunk-upgrade.yaml (1 hunks)
🔇 Additional comments (9)
.github/renovate.json5 (8)

7-8: Enable GitHub Actions manager for Renovate
Adding "github-actions" alongside "terraform" ensures Renovate will detect and manage GH Actions workflow updates.


22-24: Auto-assign code owners and dashboard cleanup
Enabling assigneesFromCodeOwners and dependencyDashboardAutoclose streamlines review and maintenance. The dynamic label {{manager}} is a nice touch—ensure Renovate supports this templating in addLabels.


27-33: Auto-merge minor/patch/pin/digest GH Actions updates
Automatically merging low-impact GitHub Actions updates reduces manual effort. Confirm that automergeType: "branch" aligns with your workflow requirements.


35-39: Group major GH Actions updates for review
Keeping major changes under "github-actions-needs-review" with the needs-review label ensures they receive proper oversight.


41-44: Group all Terraform manager updates for review
Using a "tf" group with a needs-review label on all Terraform updates is consistent with your manual review policy.


48-49: Configure OpenTofu registry for Terraform providers/modules
Pointing datasources to https://registry.opentofu.org correctly directs Renovate to your OpenTofu-based modules and providers.


54-55: Configure OpenTofu registry for required_version in .tofu files
This ensures module version constraints in .tofu files reference the correct OpenTofu registry.


60-61: Configure Terraform registry for required_version in .tf files
Using https://registry.terraform.io aligns required version checks with HashiCorp’s public registry.

.github/workflows/trunk-upgrade.yaml (1)

30-30: Expose upgrade outputs with an ID
Adding id: trunk-upgrade lets you reference pull-request-number in later steps—great enhancement.

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@gberenice gberenice merged commit b16fa86 into main May 7, 2025
4 checks passed
@gberenice gberenice deleted the feat/int-66/gha-and-renovate-updates branch May 7, 2025 14:33
gberenice pushed a commit that referenced this pull request May 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.7.0](v0.6.0...v0.7.0)
(2025-05-07)


### Features

* GHA, trunk and renovate updates
([#34](#34))
([b16fa86](b16fa86))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants