-
Notifications
You must be signed in to change notification settings - Fork 1
Adjust operation actions name #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CI/CD infrastructure and refactors the project structure. The main changes include adding GitHub Actions workflows for continuous integration and automated npm publishing, migrating to ESLint 9's flat config format, and creating a comprehensive test-project to demonstrate package usage locally.
Key Changes
- Added GitHub Actions workflows for CI (lint and test on PRs) and automated npm publishing on version tags
- Migrated from legacy ESLint configuration to ESLint 9's flat config format
- Created a test-project directory with example Dataform definitions demonstrating reservation configuration patterns
- Updated the main package to include schema in action name construction for full BigQuery table references
Reviewed Changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds CI workflow for linting and testing on pull requests |
.github/workflows/publish.yml |
Adds automated npm publishing workflow triggered by version tags |
.github/linters/eslint.config.mjs |
New ESLint 9 flat config with Dataform-specific globals |
.github/dependabot.yml |
Configures Dependabot for npm and GitHub Actions dependencies |
package.json |
Updates dependencies, removes old scripts, adds test-project compilation to test suite |
index.js |
Adds schema to action name construction for complete table references |
test/index.test.js |
Updates tests to reflect schema inclusion in action names |
test-project/* |
Adds complete test project demonstrating package functionality |
.eslintrc.js |
Removes legacy ESLint config (replaced by flat config) |
scripts/publish.js |
Removes manual publish script (replaced by GitHub Actions) |
examples.js |
Removes examples file (replaced by test-project) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…est-project lockfile
This pull request introduces several important updates to the Dataform package, focusing on improved reservation assignment logic, project structure modernization, and enhanced automation for testing and publishing. The main highlights are a breaking change to the action name format, migration to a modern ESLint configuration, and the addition of CI/CD workflows and a comprehensive test project.
Breaking change & reservation logic update:
getActionNamefunction inindex.jsto require the formatdatabase.schema.namefor operation actions, ensuring reservation assignment matches Dataform's actual behavior. This is a breaking change, so reservation configuration must now include the schema (e.g.,'my-project.my_schema.my_table').Test project & documentation:
test-project/) with example definitions and reservation configurations to verify package functionality.