Merged
Conversation
…oving manual `pre_operations` from definitions.
…m action types, introduce comprehensive testing Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
…d file, and update ESLint globals. Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
…t string or array pre-operations Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
…n tests Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
…signment and update documentation
…r automated testing and assignment improvements
…nd update workflow_settings.yaml to uncomment defaultDataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "automatic reservation" feature that allows reservation settings to be applied globally across all Dataform actions, reducing the need for repetitive, manual reservation code in each definition. The update includes helper functions, documentation, and test project changes to demonstrate and validate this new approach.
Key changes include:
New Feature: Automatic Reservation Application
applyAutomaticReservationsand supporting helpers toindex.js, enabling reservation settings to be automatically applied to all relevant actions by monkeypatching global Dataform methods. This removes the need for per-action or per-file reservation boilerplate.Documentation Updates
README.mdto document both manual and new automatic reservation application approaches, including code examples for each.Test Project Refactor
pre_operationsblocks and.preOpscalls) from all test definitions, relying instead on the new automatic reservation mechanism.test_automation.js) that demonstrates usage ofapplyAutomaticReservationsin a project context.