Skip to content

Detect hashtag links just like the web UI does #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tamschi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Detect hashtag links just like the web UI does #960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2a95eb
Detect hashtag links just like the web UI does
Tamschi Jan 8, 2025
491dff0
Detect hash at the end of the previous node of a link, not the beginning
Tamschi Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions mastodon/src/main/java/org/joinmastodon/android/ui/text/HtmlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,14 @@ public void head(@NonNull Node node, int depth){
Object linkObject=null;
String href=el.attr("href");
LinkSpan.Type linkType;
if(el.hasClass("hashtag")){
String text=el.text();
if(text.startsWith("#")){
linkType=LinkSpan.Type.HASHTAG;
href=text.substring(1);
linkObject=tagsByTag.get(text.substring(1).toLowerCase());
}else{
linkType=LinkSpan.Type.URL;
}
String text=el.text();
boolean startsWithHash=text.startsWith("#");
Node previous=el.previousSibling();
if(startsWithHash || previous != null && previous.text().endsWith("#")){
String tag=startsWithHash ? text.substring(1) : text;
linkType=LinkSpan.Type.HASHTAG;
href=tag;
linkObject=tagsByTag.get(tag.toLowerCase());
}else if(el.hasClass("mention")){
String id=idsByUrl.get(href);
if(id!=null){
Expand Down