Skip to content

Google places sdk web - remove scr script #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anggaaryas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Google places sdk web - remove scr script #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4c08b9
Update flutter_google_places_sdk_web.dart
anggaaryas Aug 13, 2024
b27229b
Update README.md
anggaaryas Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ https://developers.google.com/maps/documentation/javascript/get-api-key
Limits:
* Location restriction is not supported. See google issue tracker for more info: https://issuetracker.google.com/issues/36219203

add this script to your index.html . you can combine with another google maps library, more info: https://developers.google.com/maps/documentation/javascript/libraries#libraries-for-dynamic-library-import

```dart
<script src="https://maps.googleapis.com/maps/api/js?key={YOUR_API_KEY}&libraries=places&callback=initMap"></script>
```

## Rational

By now you probably found some other plugins, and wondering why this one was even created.
Expand Down
18 changes: 1 addition & 17 deletions flutter_google_places_sdk_web/lib/flutter_google_places_sdk_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,7 @@ class FlutterGooglePlacesSdkWebPlugin extends FlutterGooglePlacesSdkPlatform {

_initMap = allowInterop(_doInit);

html.Element? scriptExist =
html.window.document.querySelector('#$_SCRIPT_ID');
if (scriptExist != null) {
_doInit();
} else {
final body = html.window.document.querySelector('body')!;
var src =
'https://maps.googleapis.com/maps/api/js?key=${apiKey}&loading=async&libraries=places&callback=initMap';
if (locale?.languageCode != null) {
_language = locale?.languageCode;
}
body.append(html.ScriptElement()
..id = _SCRIPT_ID
..src = src
..async = true
..type = 'application/javascript');
}
_doInit();

return completer.future.then((_) {});
}
Expand Down