Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
14 changes: 14 additions & 0 deletions src/calculateRentalCost.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@
*/
function calculateRentalCost(days) {
// write code here
const pricePerDay = 40;
let result = days * pricePerDay;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses a generic name result. This violates checklist item #1: "Make names descriptive, so they explain the purpose of variables and functions." Consider renaming to totalCost or baseCost so the intent is clear.

const longRentDiscount = 50;
const mediumRentDiscount = 20;
const mediumRentDays = 3;
const longRentDays = 7;

if (days >= longRentDays) {
result -= longRentDiscount;
} else if (days >= mediumRentDays) {
result -= mediumRentDiscount;
Comment on lines +15 to +18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discount logic uses if ... else if ... rather than early returns. This violates checklist item #4: "Prefer if with return over if else to simplify later conditions." and checklist item #5: "DON'T add else after if with return - the code after it won't be executed anyway." Refactor to compute the base cost once and use early returns for long-term and short-term discounts (example in review).

}

return result;
}

module.exports = calculateRentalCost;