Skip to content

Solution #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nazikdoker79 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #6384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f5c0f6
Solution
nazikdoker79 Feb 23, 2026
3fc2dc6
fixed variable names
nazikdoker79 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/calculateRentalCost.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,23 @@
* @return {number}
*/
function calculateRentalCost(days) {
// write code here
const rentalPrice = 40;
const discountFor3OrMostday = 20;
const discountFor7OrMostday = 50;
const rentalDayForDiscount20 = 3;
const rentalDayForDiscount50 = 7;
Comment on lines +7 to +11
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you've replaced magic numbers with named constants! To make this even more readable and align with the checklist's examples, consider naming constants based on the concept they represent, rather than their value.

Also, there's a small typo in ...OrMostday; it should likely be ...OrMoreDays.

Here's a suggestion for a more conventional naming scheme:

const COST_PER_DAY = 40;
const LONG_TERM_DISCOUNT = 50;
const MEDIUM_TERM_DISCOUNT = 20;
const LONG_TERM_DAYS_THRESHOLD = 7;
const MEDIUM_TERM_DAYS_THRESHOLD = 3;


const rentalSum = rentalPrice * days;

if (days >= rentalDayForDiscount50) {
return rentalSum - discountFor7OrMostday;
}

if (days >= rentalDayForDiscount20) {
return rentalSum - discountFor3OrMostday;
}

return rentalSum;
}

module.exports = calculateRentalCost;