Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on this task! Your solution correctly implements all the logic for calculating the rental cost and passes all the checks. The code is clean, well-structured, and easy to follow. I am approving your submission.
As a minor point of feedback for future improvements, there are a couple of typos in your constant names (LONG_TERM_DISCONT and SHORT_TERM_DISCONT). Correcting these would improve the code's clarity, in line with the goal of using descriptive names [CHECKLIST ITEM #1].
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| // write code here | ||
| const PRICE_PER_DAY = 40; | ||
| const LONG_TERM = 7; | ||
| const LONG_TERM_DISCONT = 50; |
There was a problem hiding this comment.
This violates checklist item #1: 'Make names descriptive...'. There appears to be a typo in DISCONT. For better readability, consider renaming it to DISCOUNT.
| const LONG_TERM = 7; | ||
| const LONG_TERM_DISCONT = 50; | ||
| const SHORT_TERM = 3; | ||
| const SHORT_TERM_DISCONT = 20; |
There was a problem hiding this comment.
This violates checklist item #1: 'Make names descriptive...'. Similar to the variable above, this name has a typo. It would be more descriptive as SHORT_TERM_DISCOUNT.
2 participants
No description provided.