Skip to content

task solution #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task solution #2431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public class Bulldozer extends Machine {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a redundant empty line immediately after the class declaration. This violates the checklist item: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove the blank line so the first @Override appears directly after the opening brace of the class. See the checklist guidance for examples .

@Override
public void doWork() {
System.out.println("Bulldozer started it's work!");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: the printed message uses the contraction it's ("Bulldozer started it's work!"). For grammatical correctness prefer the possessive its ("Bulldozer started its work!"). The checklist requires informative English messages and this is a small polish to meet that expectation more cleanly .

}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a redundant blank line between the two method blocks. This also violates the checklist item: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line so the second @Override comes immediately after the first method's closing brace. See the checklist guidance for examples .

@Override
public void stopWork() {
System.out.println("Bulldozer stopped working!");
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is an unnecessary blank line. It violates the checklist guidance: "Please don't add redundant empty lines to your code." Remove the empty line between the package declaration and the class declaration to match the project's formatting guidelines.

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator started it's work!");
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line between the end of doWork() and the next @Override is redundant. It violates the checklist guidance: "Please don't add redundant empty lines to your code." Remove it so methods/annotations appear without unnecessary empty lines.

@Override
public void stopWork() {
System.out.println("Excavator stopped working!");
}
}
8 changes: 8 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package core.basesyntax;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant blank line after the package declaration. This violates the checklist item: "Please don't add redundant empty lines to your code." Remove the blank line so the package statement is followed immediately by the class declaration .

public abstract class Machine {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant blank line immediately after the class declaration. This violates the checklist item: "Please don't add redundant empty lines to your code." Remove this blank line so the class declaration is followed directly by its members .

public abstract void doWork();

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant blank line between method declarations. This violates the checklist item: "Please don't add redundant empty lines to your code." Remove the blank line so method signatures and their neighbors are not separated by unnecessary empty lines .

public abstract void stopWork();
}
10 changes: 10 additions & 0 deletions src/main/java/core/basesyntax/MainApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
package core.basesyntax;

public class MainApp {
public static void main(String[] args) {
Machine[] machines = new Machine[3];
machines[0] = new Bulldozer();
machines[1] = new Truck();
machines[2] = new Excavator();

for (Machine machine : machines) {
machine.doWork();
machine.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unnecessary blank line. It violates the checklist guidance: "Please don't add redundant empty lines to your code." Remove the empty line between the package declaration and the class declaration to match the project's formatting guidelines.

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck started it's work!");
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line between the end of doWork() and the next @Override is redundant and violates the checklist rule: "Please don't add redundant empty lines to your code." Remove it so the annotation and method follow immediately without an extra empty line.

@Override
public void stopWork() {
System.out.println("Truck stopped working!");
}
}