Skip to content

implemented inheritance of 3 classes and methods as well #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implemented inheritance of 3 classes and methods as well #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer is started working..");
}

@Override
public void stopWork() {
System.out.println("Bulldozer is stopped working");
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator is started working...");
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the checklist item: "Please don't add redundant empty lines to your code.\nWe don't need them after class declaration or method signature." Remove the blank line between the closing brace of doWork() and the @Override of stopWork() so the methods follow one another without an extra empty line (the blank is currently on line 8). See checklist for guidance .

@Override
public void stopWork() {
System.out.println("Excavator is stopped working.");
}
}
7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package core.basesyntax;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a redundant empty line between the package statement and the class declaration. The checklist explicitly says: "Please don't add redundant empty lines to your code." Consider removing this blank line so the class declaration immediately follows the package line. See checklist: "Please don't add redundant empty lines to your code."

public abstract class Machine {
public abstract void doWork();

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line between the two abstract method declarations is redundant. The checklist guidance states: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line so the method declarations are adjacent and follow the style guidance .

public abstract void stopWork();
}
11 changes: 11 additions & 0 deletions src/main/java/core/basesyntax/MainApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
package core.basesyntax;

public class MainApp {
public static void main(String[] args) {
Machine truck = new Truck();
Machine bullDozer = new Bulldozer();
Machine excavator = new Excavator();

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Violation — redundant empty line
This line is an unnecessary blank line inside the main method. It violates the checklist item: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Consider removing this blank line to match the project style guidelines.

Machine[] arrayOfMachines = {truck, bullDozer, excavator};

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Violation — redundant empty line
This line is another unnecessary blank line inside the main method. It also violates: "Please don't add redundant empty lines to your code. We don't need them after class declaration or method signature." Remove this blank line to comply with the checklist.

for (int i = 0; i < arrayOfMachines.length; i++) {
arrayOfMachines[i].doWork();
arrayOfMachines[i].stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains an extra blank line immediately after the package declaration. The project checklist says: "Please don't add redundant empty lines to your code." Removing this blank line will make the file consistent with the style guidance and examples in the checklist. See checklist: "We don't need them after class declaration or method signature."

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck is started working...");
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a redundant empty line between the end of doWork() and the next @Override. The checklist warns: "We don't need them after class declaration or method signature." Consider removing this blank line so method blocks follow one another directly, matching the recommended style.

@Override
public void stopWork() {
System.out.println("Truck is stopped working.");
}
}