added pswm method with Hello World message#2515
added pswm method with Hello World message#2515ursusandwolf wants to merge 5 commits intomate-academy:masterfrom
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes as the submission appears to be a placeholder and is missing the core implementation. To meet the requirements, you'll need to create the Machine, Truck, Bulldozer, and Excavator classes. The Machine class should be abstract with abstract doWork() and stopWork() methods, which the other classes must extend and implement. Finally, in the MainApp class, please create an array of these machines and call their doWork() and stopWork() methods inside a loop. You're on the right track by setting up the project structure, now let's get the implementation in place!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
all fixed, check it please |
# Conflicts: # src/main/java/core/basesyntax/Bulldozer.java # src/main/java/core/basesyntax/Excavator.java # src/main/java/core/basesyntax/Machine.java # src/main/java/core/basesyntax/MainApp.java # src/main/java/core/basesyntax/Truck.java
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am approving your solution as it perfectly meets all the task requirements. You've demonstrated a clear understanding of inheritance and polymorphism by correctly using an abstract Machine class and its subclasses. The MainApp is well-implemented, showcasing how to work with objects through a common abstract reference. The code is clean, correct, and functions exactly as expected. Keep up the great progress!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
Hello World message