Skip to content

MaksymGorodnychyi#2542

Open
MaksymGorodnychyi wants to merge 1 commit intomate-academy:masterfrom
MaksymGorodnychyi:master
Open

MaksymGorodnychyi#2542
MaksymGorodnychyi wants to merge 1 commit intomate-academy:masterfrom
MaksymGorodnychyi:master

Conversation

@MaksymGorodnychyi
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! You've correctly implemented the abstract Machine class and its subclasses, demonstrating a solid understanding of polymorphism in the MainApp. All functional requirements have been met, so I am happy to approve your solution.

Just a small note on code style for the future: please be mindful of redundant empty lines, like the ones found in Machine.java. This is a minor point that doesn't affect functionality but is good practice to follow [CHECKLIST ITEM #1]. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +7 to +8


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Please don't add redundant empty lines to your code.' These empty lines after the class declaration are not needed.

Copy link
Copy Markdown

@Elena-Bruyako Elena-Bruyako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job
Just be carefull with empty lines

Comment on lines +3 to +8
public abstract class Machine {
public abstract void doWork();
public abstract void stopWork();
}


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public abstract class Machine {
public abstract void doWork();
public abstract void stopWork();
}
public abstract class Machine {
public abstract void doWork();
public abstract void stopWork();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants